[PATCH] hgweb: fix url base generation to handle absolute paths in baseurl

Matt Mackall mpm at selenic.com
Wed May 20 11:05:59 CDT 2009


On Wed, May 20, 2009 at 03:48:30PM +0200, Dirkjan Ochtman wrote:
> Okay, this is a hard problem... I'm not sure the patch gets everything 
> right yet. Let's see...
> 
> On 14/05/2009 22:14, Alexander Solovyov wrote:
> > -        req.url = req.env['SCRIPT_NAME']
> > +        req.url = self.config('web', 'baseurl', req.env['SCRIPT_NAME'])
> 
> Can you explain what SCRIPT_NAME looks like?

In fact, it'd probably be good to document this whole thing fairly
carefully in the comments, preferably in some tabular form. We end up
retreading this a lot and missing cases each time.

-- 
Mathematics is the supreme nostalgia of our time.


More information about the Mercurial-devel mailing list