[PATCH 0 of 3] patches for TortoiseHg overlay icons

Adrian Buehlmann adrian at cadifra.com
Wed May 20 17:20:29 CDT 2009


On 20.05.2009 23:21, Matt Mackall wrote:
> I really don't like the 1s thing. It can bite us on very simple
> operations that should take < .1s. Putting it in is a step away from
> solving the problem correctly.

I see. Thanks a lot for looking into this.

But the 'postupdate' hook patch would still be very useful, as
we could trigger follow-up status cache / icon updates with it
in the explorer extension (or future components) of TortoiseHg
on Windows.

The currently available 'update' hook is just not generic enough,
and it is triggered _before_ updating .hg/dirstate. What we need
to show in explorer is the endresult.

Also, the 'update' hook is not triggered in other interesting
situations when we would need a call (e.g. rollback, hg qpush,
hg whatever).

Sure, we can additionally subscribe to  the 'commit' hook as well,
but what about commands from extensions?

The 'post-<cmd>' hook system does not fit either, as we don't
know all commands from extensions in advance. And subscribing to
a whole bunch of commands is inelegant and harder to verify.



More information about the Mercurial-devel mailing list