[PATCH] setup.py: subprocess instead of os.popen, sys.stderr.write instead of print

Christian Ebert blacktrash at gmx.net
Fri May 22 14:33:57 CDT 2009


* Martin Geisler on Friday, May 22, 2009 at 20:49:43 +0200
> Christian Ebert <blacktrash at gmx.net> writes:
>> # HG changeset patch
>> # User Christian Ebert <blacktrash at gmx.net>
>> # Date 1242995218 -7200
>> # Node ID 2356e98d3b411e11b403db9e050adbf61f6a314e
>> # Parent  9f0d085469c53401ecea64d4a3691a119ac19116
>> setup.py: subprocess instead of os.popen, sys.stderr.write instead of print
> 
> Thanks, it's in crew as 548fd7a05373!

Thank you.

I suppose this stanza from ui.write_err (oops an underscore ;-) )
is not needed in the setup.py context:

    # stderr may be buffered under win32 when redirected to files,
    # including stdout.
    if not sys.stderr.closed: sys.stderr.flush()
 
?

I don't have windows so ...

c
-- 
\black\trash movie    _C O W B O Y_  _C A N O E_  _C O M A_
Ein deutscher Western/A German Western
-->> http://www.blacktrash.org/underdogma/ccc.html
-->> http://www.blacktrash.org/underdogma/ccc-en.html


More information about the Mercurial-devel mailing list