[PATCH] setup.py: subprocess instead of os.popen, sys.stderr.write instead of print

[Martin Geisler]

Christian Ebert <blacktrash at gmx.net> writes:

> * Martin Geisler on Friday, May 22, 2009 at 20:49:43 +0200
>> Christian Ebert <blacktrash at gmx.net> writes:
>>> # HG changeset patch
>>> # User Christian Ebert <blacktrash at gmx.net>
>>> # Date 1242995218 -7200
>>> # Node ID 2356e98d3b411e11b403db9e050adbf61f6a314e
>>> # Parent  9f0d085469c53401ecea64d4a3691a119ac19116
>>> setup.py: subprocess instead of os.popen, sys.stderr.write instead of print
>> 
>> Thanks, it's in crew as 548fd7a05373!
>
> Thank you.
>
> I suppose this stanza from ui.write_err (oops an underscore ;-) )
> is not needed in the setup.py context:
>
>     # stderr may be buffered under win32 when redirected to files,
>     # including stdout.
>     if not sys.stderr.closed: sys.stderr.flush()

I guess not since the call to setup.py should't be redirected
anywhere... But the Windows people will have to test and see :-)

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090522/9d535a8f/attachment.pgp