mercurial at 8549: 46 new changesets

Christian Ebert blacktrash at gmx.net
Sat May 23 03:03:07 CDT 2009


Hi Martin,

* Mercurial Commits on Saturday, May 23, 2009 at 02:15:50 +0200
> 46 new changesets in mercurial:

[...]

> http://www.selenic.com/hg/rev/9f85da260508
> changeset:   8549:9f85da260508
> tag:         tip
> user:        Martin Geisler <mg at lazybytes.net>
> date:        Sat May 23 00:24:00 2009 +0200
> summary:     setup: add missing newline in warning

Nitpick: Have you tried it? At least here stderr=subprocess.PIPE
seems to already append a newline. Which is why I omitted it
after comparing a warning output of new and old versions.

But your line wrap is way nicer, and an empty line after the
warning is better for readability, so I'm fine with that change
;-)

Speaking of readability, imho this would even be better:

        sys.stderr.write('warning: could not establish Mercurial '
                         'version:\n%s\n' % e)

<duck>

c
-- 
\black\trash movie    _C O W B O Y_  _C A N O E_  _C O M A_
Ein deutscher Western/A German Western
-->> http://www.blacktrash.org/underdogma/ccc.html
-->> http://www.blacktrash.org/underdogma/ccc-en.html


More information about the Mercurial-devel mailing list