mercurial at 8549: 46 new changesets

Martin Geisler mg at lazybytes.net
Sat May 23 06:44:15 CDT 2009


Christian Ebert <blacktrash at gmx.net> writes:

> Hi Martin,
>
> * Mercurial Commits on Saturday, May 23, 2009 at 02:15:50 +0200
>> 46 new changesets in mercurial:
>
> [...]
>
>> http://www.selenic.com/hg/rev/9f85da260508
>> changeset:   8549:9f85da260508
>> tag:         tip
>> user:        Martin Geisler <mg at lazybytes.net>
>> date:        Sat May 23 00:24:00 2009 +0200
>> summary:     setup: add missing newline in warning
>
> Nitpick: Have you tried it? At least here stderr=subprocess.PIPE
> seems to already append a newline. Which is why I omitted it
> after comparing a warning output of new and old versions.

I did try it, but I guess that was before the newline change.

> But your line wrap is way nicer, and an empty line after the
> warning is better for readability, so I'm fine with that change
> ;-)
>
> Speaking of readability, imho this would even be better:
>
>         sys.stderr.write('warning: could not establish Mercurial '
>                          'version:\n%s\n' % e)
>
> <duck>

Done!

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090523/36ebd2df/attachment.pgp 


More information about the Mercurial-devel mailing list