mercurial at 8549: 46 new changesets

[Steve Borho]

On Sat, May 23, 2009 at 6:44 AM, Martin Geisler <mg at lazybytes.net> wrote:
> Christian Ebert <blacktrash at gmx.net> writes:
>
>> Hi Martin,
>>
>> * Mercurial Commits on Saturday, May 23, 2009 at 02:15:50 +0200
>>> 46 new changesets in mercurial:
>>
>> [...]
>>
>>> http://www.selenic.com/hg/rev/9f85da260508
>>> changeset:   8549:9f85da260508
>>> tag:         tip
>>> user:        Martin Geisler <mg at lazybytes.net>
>>> date:        Sat May 23 00:24:00 2009 +0200
>>> summary:     setup: add missing newline in warning
>>
>> Nitpick: Have you tried it? At least here stderr=subprocess.PIPE
>> seems to already append a newline. Which is why I omitted it
>> after comparing a warning output of new and old versions.
>
> I did try it, but I guess that was before the newline change.
>
>> But your line wrap is way nicer, and an empty line after the
>> warning is better for readability, so I'm fine with that change
>> ;-)
>>
>> Speaking of readability, imho this would even be better:
>>
>>         sys.stderr.write('warning: could not establish Mercurial '
>>                          'version:\n%s\n' % e)
>>
>> <duck>
>
> Done!

Not yet, unfortunately (apologies for the line wrapping)

warning: could not establish Mercurial version:
warning: Not importing directory 'C:\Documents and Settings\Gayle\thg-installer\
hg-main\locale': missing __init__.py
Traceback (most recent call last):
  File "hg", line 25, in <module>
    mercurial.util.set_binary(fp)
  File "C:\Documents and Settings\Gayle\thg-installer\hg-main\mercurial\demandim
port.py", line 75, in __getattribute__
    self._load()
  File "C:\Documents and Settings\Gayle\thg-installer\hg-main\mercurial\demandim
port.py", line 47, in _load
    mod = _origimport(head, globals, locals)
  File "C:\Documents and Settings\Gayle\thg-installer\hg-main\mercurial\util.py"
, line 742, in <module>
    from windows import *
  File "C:\Documents and Settings\Gayle\thg-installer\hg-main\mercurial\demandim
port.py", line 84, in _demandimport
    return _origimport(name, globals, locals, fromlist)
  File "C:\Documents and Settings\Gayle\thg-installer\hg-main\mercurial\windows.
py", line 21, in <module>
    posixfile.__doc__ = osutil.posixfile.__doc__
  File "C:\Documents and Settings\Gayle\thg-installer\hg-main\mercurial\demandim
port.py", line 76, in __getattribute__
    return getattr(self._module, attr)
AttributeError: 'module' object has no attribute 'posixfile'