[PATCH] paramiter to show folder navigation in web view instead of listing all repositories in the hgweb.conf
Martin Geisler
mg at lazybytes.net
Wed May 27 04:37:41 CDT 2009
Diego de Oliveira <lokimad at gmail.com> writes:
Hi Diego,
I have not looked at the actual functionality in your patch, but I
looked a bit at the code style. Please see the comments below.
> # HG changeset patch
> # User diego at diegooliveira.com
> # Date 1243388298 10800
> # Node ID 8efe071dffc73bf6f3062d1fbaa422780d80172d
> # Parent c31fe74a66335b99907ce622eb8d79f372db3f81
> paramiter to show folder navigation in web view instead of listing all repositories in the hgweb.conf
Try to keep the first line in a commit message below ~70 characters.
That way it wont be wrapped when we look at 'hg log' in a normal
terminal.
> diff -r c31fe74a6633 -r 8efe071dffc7 doc/hgrc.5.txt
> --- a/doc/hgrc.5.txt Tue May 26 23:49:53 2009 +0200
> +++ b/doc/hgrc.5.txt Tue May 26 22:38:18 2009 -0300
> @@ -786,6 +786,10 @@
> Example: "UTF-8"
> errorlog;;
> Where to output the error log. Default is stderr.
> + folderview;;
> + Shows the folders for navigation if using a collections of repositories
> + in paths. Instead of show "Folder\Repository" will show just
> + "Folder\".
We always use forward slashes ("/") instead of backslashes ("\") in
path names, so this looks weird.
> + paths = {'' : '' }
> for name, path in self.repos:
> if not name.startswith(subdir):
> continue
> name = name[len(subdir):]
> -
> +
Whitespace change -- you added ' ' to the line.
> + def isRepository(rootPath, u):
You're using a camelCasing code style. Please take a look at
http://www.selenic.com/mercurial/wiki/BasicCodingStyle
and adjust your patch (provided that someone else thinks it's a good
functionality, I didn't look at that).
--
Martin Geisler
VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
More information about the Mercurial-devel
mailing list