[PATCH] paramiter to show folder navigation in web view instead of listing all repositories in the hgweb.conf
Dirkjan Ochtman
dirkjan at ochtman.nl
Wed May 27 04:41:59 CDT 2009
On Wed, May 27, 2009 at 11:37 AM, Martin Geisler <mg at lazybytes.net> wrote:
> Diego de Oliveira <lokimad at gmail.com> writes:
> I have not looked at the actual functionality in your patch, but I
> looked a bit at the code style. Please see the comments below.
Right, the style isn't very good, so you'd have to address that.
Second, while I think the idea is good, I don't much like your
implementation. I think the option should probably be named 'descend'
(and default to true), and it should be implemented by making some
changes to hgwebdir_mod.py in hgwebdir.run_wsgi(), lines 140-170. That
seems cleaner than filtering in entries, and saves the overhead of
walking directories you don't want to display anyway.
Cheers,
Dirkjan
More information about the Mercurial-devel
mailing list