[PATCH] patchbomb: allow multiple addresses in a single --to/cc/bcc argument

Sune Foldager cryo at cyanite.org
Sun Nov 1 03:12:59 CST 2009

Marti Raudsepp wrote:

> Here's a patch to fix up the current patchbomb behavior that doesn't
> allow multiple addresses separated by commas on command line.
> The current behavior is quite surprising: 'hg email --to foo,bar'
> silently discarded 'bar' recipient. You wouldn't realize the mistake
> until you actually peek into the headers. The help screen suggests it
> accepts "email addresses" as the argument.

Hmm, I don't know... While the code change is small, and the code looks
good, I still find the feature a bit weird. I mean, then we should also
change other commands which take multiple arguments to accept comma
separated lists? Or is this because the configuration is done with
commas (due to the way the config format works, I guess)?

I guess it'll not mess things up for people used to the existing
behavior, but it still strikes me as a bit odd :-p. Let's see what
others think :-).


More information about the Mercurial-devel mailing list