reverse function in applydiff

[Martin Geisler]

TK Soh <teekaysoh at gmail.com> writes:

> On Tue, Nov 3, 2009 at 3:07 AM, TK Soh <teekaysoh at gmail.com> wrote:
>> I just notice that the reverse function in patch.applydiff used by
>> hgshelve has been removed:
>>
>> changeset:   9393:23c4e772c172
>> user:        Nicolas Dumazet <nicdumz.commits at gmail.com>
>> date:        Sun Aug 23 14:32:58 2009 +0200
>> summary:     patch: remove the unused, broken reverse() function
>>
>> Any suggestion on how to fix this before 1.4?
>
> BTW, it's not very clear from the commit message what exactly is
> broken in reverse() function.

Yeah, I agree that it would have been nice if the commit message had
explained what is wrong.

> Instead of simply removing the support, can't it be fixed?

Don't know -- I've CC'ed Nicolas and I hope he can find a solution.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.