reverse function in applydiff

Steve Borho steve at borho.org
Tue Nov 3 09:11:07 CST 2009


On Tue, Nov 3, 2009 at 5:25 AM, Patrick Mézard <pmezard at gmail.com> wrote:
> Martin Geisler a écrit :
>> Patrick Mézard <pmezard at gmail.com> writes:
>>
>>> TK Soh a écrit :
>>>> I just notice that the reverse function in patch.applydiff used by
>>>> hgshelve has been removed:
>>>>
>>>> changeset:   9393:23c4e772c172
>>>> user:        Nicolas Dumazet <nicdumz.commits at gmail.com>
>>>> date:        Sun Aug 23 14:32:58 2009 +0200
>>>> summary:     patch: remove the unused, broken reverse() function
>>>>
>>>> Any suggestion on how to fix this before 1.4?
>>> Where is it used ?
>>
>> In hgshelve, just about here:
>>
>>   http://bitbucket.org/tksoh/hgshelve/src/tip/hgshelve.py#cl-39
>
> Couldn't we officially recognize that hgshelve is deprecated in favor of the attic extension ?

I don't think hgshelve.py actually uses the reverse argument.  I think
it can simply drop it from the call to applydiff.

--
Steve Borho



More information about the Mercurial-devel mailing list