[PATCH] patchbomb: allow multiple addresses in a single --to/cc/bcc argument

[Martin Geisler]

Marti Raudsepp <marti at juffo.org> writes:

> Hi,
>
> Here's a patch to fix up the current patchbomb behavior that doesn't
> allow multiple addresses separated by commas on command line.
>
> The current behavior is quite surprising: 'hg email --to foo,bar'
> silently discarded 'bar' recipient. You wouldn't realize the mistake
> until you actually peek into the headers. The help screen suggests it
> accepts "email addresses" as the argument.

As you already know, the "proper" way to do this is to repeat the --to
option as needed. But I can definitely see why this surprices you since
we're so used to entering multiple emails with commas as a separator.

So the question is: do we want to support just email addresses or do we
want to support name+address?

I would be fine with saying that we only support email addresses, which
makes timeless' example of "Smith, David" <david.smith at example.com>
invalid.

Is a a comma allowed in an address? I know that the RFC allows the most
surpricing addresses, so I wouldn't be surpriced if a comma is legal
too... But even so, we might want to say that we don't support it.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20091103/fd4a2d27/attachment.pgp