[PATCH 0 of 3] Improve email address parsing

Matt Mackall mpm at selenic.com
Wed Nov 4 14:14:27 CST 2009


On Wed, 2009-11-04 at 19:53 +0200, Marti Raudsepp wrote:
> Hi list,
> 
> This series improves email address parsing in Mercurial, particularly
> for use with the patchbomb extension. It's an improvement over version 2
> of my multiple addresses patch, incorporating Martin Geisler's feedback.

Can't say I'm excited by this. We've already got a perfectly good,
clean, safe, and easy to parse way to pass multiple arguments and I
don't think "mail programs do it differently" is a good argument for us
to do it differently in exactly one place. 

Mail programs do it differently because in the pre-SMTP olden days it
was easy and clean to parse such list because usernames were simple
[a-z0-9] character strings and "-c alice,bob,charlie" wasn't a confusing
abomination on the command line. Those days are long gone and it now
makes much more sense to do "-c 'Alice Liddell <alice at wonderland.com>'
-c ...". 

And I certainly don't want to add comma lists everywhere we support
repeated arguments. I think this is best addressed with an example in
the docs.

> The 3rd patch is new and has not been posted until now.

Yeah, we'll probably need something like that.

-- 
http://selenic.com : development and support for Mercurial and Linux




More information about the Mercurial-devel mailing list