[PATCH 0 of 3] Improve email address parsing

Matt Mackall mpm at selenic.com
Wed Nov 4 16:23:35 CST 2009


On Wed, 2009-11-04 at 22:33 +0100, Sune Foldager wrote:
> Matt Mackall wrote:
> > On Wed, 2009-11-04 at 19:53 +0200, Marti Raudsepp wrote:
> >> Hi list,
> >>
> >> This series improves email address parsing in Mercurial, particularly
> >> for use with the patchbomb extension. It's an improvement over version 2
> >> of my multiple addresses patch, incorporating Martin Geisler's feedback.
> > 
> > Can't say I'm excited by this. We've already got a perfectly good,
> > clean, safe, and easy to parse way to pass multiple arguments and I
> > don't think "mail programs do it differently" is a good argument for us
> > to do it differently in exactly one place. 
> 
> This was also my original objection: it's a clash of conventions.
> Mercurial's repeat-the-option convention and the email program (hg isn't
> one) convention of specifying multiple addresses.
> 
> Of course you can do so in the config file, but that's a different story.

It's been pointed out to me that keeping this parsing logic for the
config file is probably a good idea.

-- 
http://selenic.com : development and support for Mercurial and Linux




More information about the Mercurial-devel mailing list