[PATCH 0 of 2] Issue919: add a standard extension to recreate hardlinks between repositories

Jesse Glick typrase at gmail.com
Thu Nov 5 15:48:20 CST 2009


Benoit Boissinot wrote:
> - It would be better to have relink be a "repo" command,
>   e.g. "hg relink foo" to relink the repo you're in based on foo
>   "hg relink" would look at the default path (and maybe first look if a
>   default-relink is defined?)

done

> - It should probably lock both repos while the extension is running

done

> - It could use repo.store.walk() or repo.store.datafiles() to find the
>   revlogs.

I played with repo.store.walk() but it did not look helpful.

1. Would make the patch more disruptive and more likely to be buggy, without being noticeably clearer.

2. Several things in walk() would be done unnecessarily - decoding fncache, util.pconvert, but especially the extra stat.

> - Please try to separate the patches, so that it's easier to review (and
>   the non-controversial bits could be applied directly)

Not sure what exactly the patch should be separated into...?

Please also keep me CC'd on replies.


More information about the Mercurial-devel mailing list