[PATCH 0 of 1] Issue919: add a standard extension to recreate hardlinks between repositories

[Jesse Glick]

Benoit Boissinot wrote:
> lowercase for status messages, please.

Done (5x).

> You could take both locks at the same time

Not while assuring that both get released, even if acquiring one throws an exception. Will change it if you still want but seems slightly less safe.

> (and remotelock is a better name for lock2)

Done.

> here using the store stuff, you would be able to relink repo with a
> different store encoding

Perhaps so, but is this likely to ever happen? And would only help for the tiny minority of files using non-ASCII characters in their names anyway. For code like this (which could corrupt data if wrong), better safe and simple I think.

> better help text if possible.

There is extensive help text in the method itself. I checked both 'hg help' and 'hg help relink'. The cmdtable would only include further text if there were any options.

> I'd leave that out, I'm unsure about advertising extensions in core hg
> like that and a warning is a bit too verbose in my opinion.

Changed to a brief note in the clone help text.

Also reduced size of diff in collect function.