[PATCH 3 of 3] mail: fix handling of email addresses with Unicode domains (IDNA)

Christian Ebert blacktrash at gmx.net
Fri Nov 6 05:19:34 CST 2009


* Benoit Boissinot on Friday, November 06, 2009 at 11:42:12 +0100
> On Thu, Nov 05, 2009 at 11:59:15AM +0100, Dirkjan Ochtman wrote:
>> On Wed, Nov 4, 2009 at 18:53, Marti Raudsepp <marti at juffo.org> wrote:
>>> # HG changeset patch
>>> # User Marti Raudsepp <marti at juffo.org>
>>> # Date 1257356232 -7200
>>> # Node ID f20bad63a3d374b38c1c1fdde05988e09bde8a00
>>> # Parent  e54459b6f1e21ebf847bbfb5d468eb25b179ee53
>>> mail: fix handling of email addresses with Unicode domains (IDNA)
>>> 
>>> dom.encode('idna') requires dom to be a Unicode string.
>> 
>> I've put this in crew:
>> 
>> changeset:   9715:f0e99a2eac76
>> user:        Marti Raudsepp <marti at juffo.org>
>> date:        Thu Nov 05 10:49:28 2009 +0100
>> summary:     patchbomb: fix handling of email addresses with Unicode
>> domains (IDNA)
>> 
>> (Had to re-do the test because it was relying on the other patches.)
>> 
> 
> It breaks here (ubuntu karmic):
> 
> ERROR: test-patchbomb output changed
> --- Expected output 
> +++ Test output 
> @@ -1484,7 +1484,7 @@
> User-Agent: Mercurial-patchbomb
> Date: Tue, 01 Jan 1980 00:01:00 +0000
> From: quux
> -To: bar at xn--nicode-2ya.com
> +To: bar at -en\xfcnicode.com
> 
> # HG changeset patch
> # User test

Similar failure on MacOS X:

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.5.8
BuildVersion:	9L30
$ ./run-tests.py test-patchbomb

ERROR: test-patchbomb output changed
--- Expected output
+++ Test output
@@ -1484,7 +1484,7 @@
 User-Agent: Mercurial-patchbomb
 Date: Tue, 01 Jan 1980 00:01:00 +0000
 From: quux
-To: bar at xn--nicode-2ya.com
+To: bar at xn---ennicode-s9a.com

 # HG changeset patch
 # User test
!
Failed test-patchbomb: output changed
# Ran 1 tests, 0 skipped, 1 failed.


c
-- 
  Was heißt hier Dogma, ich bin Underdogma!
[ What the hell do you mean dogma, I am underdogma. ]

_F R E E_  _V I D E O S_  --->>> http://www.blacktrash.org/underdogma/


More information about the Mercurial-devel mailing list