Analysis of issue 1327

Sune Foldager cryo at cyanite.org
Fri Nov 6 11:53:43 CST 2009


Greg Ward wrote:
> 
> Thank you!  That was very illuminating.  I'm pretty sure this is the
> root cause of issue1839 ("annotate ignores topology of changelog graph
> (sometimes?)") too.

Ah, yes, I should suspect so.

>> 2. SOLUTIONS
>>
>> In general, there are two ways to address this: Fix the filelogs to be
>> correct, or fix all the uses of the filelog.
> 
> Strong +1 on fixing the filelog, because that should fix other bugs
> (e.g. 1839) for free.

Yes, this is also my preference

>> A better (with respect to design, prettyness and performance) approach
>> is to change the revlog format slightly to support metadata in a native
>> way. This can be done in the following way:
> 
> This sounds preferable to me.  Mercurial has made format changes in
> the past to fix bugs, and adding generic metadata support to filelogs
> sounds very sensible.

Yes, especially since filelogs DO use metadata currently, but they are
hacked in pretty much, and regress performance (apparently) when they
are present (for copies).

Thank's a lot for the feedback :)

/Sune



More information about the Mercurial-devel mailing list