[PATCH 0 of 6] refactor buildrpm script

Mads Kiilerich mads at kiilerich.com
Sat Nov 7 19:59:07 CST 2009


Matt Mackall wrote, On 11/07/2009 01:41 AM:
> On Fri, Nov 06, 2009 at 10:07:16AM +0100, Gilles Moris wrote:
>> This is basically the same script change I already sent but splitted in
>> several patches for easier review. For the record:
>
> I'm fairly indifferent about the spec file,

These patches doesn't touch the spec file - they only touches the 
contrib/buildrpm shell script which can be used to build an rpm from a 
repo using the spec file.

I think these patches ar fine improvements and fixes several bugs and 
inconveniences and could be applied - even though they still leave room 
for improvement.

Bos mentioned on IRC that he has no special interest in the script any 
more. (Perhaps his name should be removed from the script?)

> but I would like to see us
> get to the point where the rpm-based distros actually use it. So I'd
> like to see an ack from a packager.

An RPM spec references a tar file, so there is no way the distros can 
use the spec file _in_ the release tar balls directly. We could try to 
keep them in sync, but I think that they have different purposes: The 
Mercurial spec should try to be as simple as possible, while Fedora spec 
tries to comply with guidelines and integrate as good as possible with 
the system.

/Mads


More information about the Mercurial-devel mailing list