[PATCH] mercurial.spec: Update to version from Fedora 12

Gilles Moris gilles.moris at free.fr
Mon Nov 9 03:02:04 CST 2009


On Sunday 08 November 2009 11:59:49 pm Mads Kiilerich wrote:
> Matt Mackall wrote, On 11/08/2009 04:42 PM:
> > On Sun, 2009-11-08 at 02:38 +0000, Mads Kiilerich wrote:
> >> I suggest _not_ applying this patch but staying where we are, possibly
> >> with some minor improvements.
> >
> > Ok. Care to review Gilles' patches?
>
> I have reviewed it and we have discussed it a lot in private mail. We
> have been discussing very minor details the last couple of rounds. I
> think the changes are good, does a long needed cleanup and leaves the
> script in better shape than ever. I think Gilles will post a new bomb
> with some minor changes. I recommend applying them. (But the current
> version is fine too.)
>

I will resend the series shortly, with the few fixes from Mads.
I am currently installing Fedora 11 and Mandriva 2010 to test the script on 
those distros.
The script itself should be pretty portable on any distro supporting RPMs, 
compared to the spec files. I tried to avoid bash-isms, though I don't know 
if it can be useful.

> On open question is what use cases we want to support and how big and
> smart and user friendly and complex we want the script to be. For
> example, I think we should drop the generated changelog from the spec.
> IMHO it is complex, misses the point for package changelogs, and adds no
> real value. But that is no big issue.
>

For the use case, I am addressing people that wants to quickly create an 
official tag or a snapshot build. As Mads told us, each distro seems to have 
its own customized spec file and build process. So the spec file and buildrpm 
script is probably interesting for them as a starting point.

In the case of individuals wanted to have a quick RPM snapshot or nightly 
build, I think this changelog can be useful to quickly check the date of the 
snapshot and if the snapshot contains the fixes/feature you are looking for.
But I agree that RPM changelog was more intended to track changes of the spec 
file or of the overlay patches.

Regards.
Gilles.


More information about the Mercurial-devel mailing list