[PATCH] test-extension: Solaris grep don't know [[:digit:]]

Mads Kiilerich mads at kiilerich.com
Tue Nov 10 09:57:23 CST 2009


On 11/10/2009 04:19 PM, timeless wrote:
> Mads Kiilerich wrote:
>>>> -    | grep '^[[:digit:]]) [[:alnum:] ]*$'  # ignores HTML output
>>>> +    | grep '^[0-9]) ' # ignores HTML output
>
> timeless wrote:
>> what happened to :alnum: ?
>
> Mads Kiilerich wrote:
>> why do you ask
>
> Please note that the commit message for this change was caught by my
> spam filter, so I didn't see it and hence didn't know this was a
> closed change.
>
> I asked because it's kind of strange to drop one item while claiming
> to merely change another item.

Yes, I could have written a longer and more descriptive description, but 
I felt that the short one was sufficient and thus better.

The regexp failed, and I replaced it with a simpler and more portable 
and more maintainable one. The subject explains _why_, the diff clearly 
shows _what_ the change was. Spending more words on that would be a 
waste of time, IMHO.

/Mads


More information about the Mercurial-devel mailing list