[PATCH 0 of 2] inotify: daemonizing and children pids

Nicolas Dumazet nicdumz at gmail.com
Tue Nov 17 01:22:36 CST 2009


Hello,

Two patches:
* First one is an important fix. It solves issue1811, but also a very
  bad regression due to 7c01599dd340, which breaks inotify when not started
  explicitely :/
* The second patch try to solve the complains I heard yesterday, when
  test-inotify-dirty-dirstate was leaking and failing unrelated tests. It now
  allows us to set a inotify.pidfile option to know the pids of the new
  inotify children.

With inotify.pidfile option, it should be possible to add an --inotify flag
to the test runner, to run our test base with inotify activated. This should
greatly improve test coverage with inotify.

There's a (small) issue for now: pid files are overwritten in the implementation
of cmdutil.service, which makes it hard to wrap tests using several local
repositories (thus launching several inotify servers)

I'm thinking of passing an option/parameter to change the pid file flag from 'w'
to 'a', to use that inotify.pidfile to list all the inotify servers started
system-wide instead of only the last one: after this, test runner will be able
to catch all the inotify processes and kill them before starting the next test.
Can you think of a cleaner way to do this?

Thanks,
Nicolas.


More information about the Mercurial-devel mailing list