[PATCH STABLE] qseries: don't truncate the patch name (issue1912)

[Dan Villiom Podlaski Christiansen]

On 17 Nov 2009, at 22:08, Martin Geisler wrote:

> Dan Villiom Podlaski Christiansen <danchr at gmail.com> writes:
> 
>> On 17 Nov 2009, at 21:22, Martin Geisler wrote:
>> 
>>> Dan Villiom Podlaski Christiansen <danchr at gmail.com> writes:
>>> 
>>>> I probably should mention that I haven't tested this patch rigorously :)
>>> 
>>> Well, then please write a test case :-)
>>> 
>>>> Does it fix the issue?
>>> 
>>> I haven't tried it yet -- we should get a test case for this to
>>> prevent future regressions.
>> 
>> Yeah, but how? :) I couldn't get it to fail; is ui.interactive()
>> always false during the tests?
> 
> Yes since hg is not talking to a tty. However, grepping for
> 'interactive' in the tests reveals a trick: test-diffstat does
> 
>  COLUMNS=24 hg diff --config ui.interactive=true --stat
> 
> to re-enable ui.interactive.

Indeed, it worked — and even found a bug in my code :)

I've sent an updated patch including the tests.

--

Dan Villiom Podlaski Christiansen
danchr at gmail.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1943 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20091117/24127168/attachment.bin>