Rollback ate my commit message! (issue 1635)

[Dan Villiom Podlaski Christiansen]

On 18 Nov 2009, at 22:15, Martin Geisler wrote:

> As far as I know, rollback only knows some file lengths. It truncates
> the files back to the last good length -- Mercurial is append-only, so
> this effectively undoes the last operation.
> 
> I'm not sure why we only save the very last lengths?

Perhaps because not all operations are safely reversible? An actual undo stack might require a fair amount of testing to make sure it really works…

Back on topic, how about extending the journal? When performing a commit, the message could be stored in the journal. This would then allow ‘rollback’ to distinguish commits and restore the deleted message somehow. Or simply print it. Does this make sense?

--

Dan Villiom Podlaski Christiansen
danchr at gmail.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1943 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20091118/4b944b50/attachment.bin>