[PATCH 0 of 2] inotify: daemonizing and children pids

[Nicolas Dumazet]

2009/11/17 Nicolas Dumazet <nicdumz at gmail.com>:
[...]
> With inotify.pidfile option, it should be possible to add an --inotify flag
> to the test runner, to run our test base with inotify activated. This should
> greatly improve test coverage with inotify.
>
> There's a (small) issue for now: pid files are overwritten in the implementation
> of cmdutil.service, which makes it hard to wrap tests using several local
> repositories (thus launching several inotify servers)
>
> I'm thinking of passing an option/parameter to change the pid file flag from 'w'
> to 'a', to use that inotify.pidfile to list all the inotify servers started
> system-wide instead of only the last one: after this, test runner will be able
> to catch all the inotify processes and kill them before starting the next test.
> Can you think of a cleaner way to do this?
>

Just as a follow-up, I was thinking of this kind of patch:
http://bitbucket.org/nicdumz/mercurial-crew-mq/src/dfcdd2a18c5c/runtest-inotify

It might not be perfect for now, but it allows me to easily spot what
needs improvements in the extension. And there's a lot to do:
http://bitbucket.org/nicdumz/mercurial-crew-mq/wiki/Home :)

I'm not sure if crew could use the --inotify option: it is going to
show unsignificant failures for a lot of tests, and it's useless for
you folks if I dont add some kind of "inotify blacklist" feature, or
some tests/inotify-outs/[testname].out alternative outputs. For now it
will stay in my MQ, and I'll see if I can make it generic enough when
more failures will be fixed.

-- 
Nicolas Dumazet — NicDumZ