[PATCH] Fix -r option in 'hg help clone'

Adrian Buehlmann adrian at cadifra.com
Thu Nov 19 07:10:39 CST 2009


On 19.11.2009 12:44, timeless wrote:
> On Thu, Nov 19, 2009 at 11:57 AM, Adrian Buehlmann <adrian at cadifra.com> wrote:
>> We do have in the main part of clone's help text:
>>
>> '''
>>    A set of changesets (tags, or branch names) to pull may be specified by
>>    listing each changeset (tag, or branch name) with -r/--rev. If -r/--rev is
>>    used, the cloned repository will contain only a subset of the changesets
>>    of the source repository. Only the set of changesets defined by all
> 
> Ouch. I think now might be a time to flag "all" as problematic, is
> this a union or intersection? (we mean intersection, but as a reader
> I'd at least half expect it to mean intersection)
> 

I suggest that people make out-of scope (for a patch) suggestions
in a separate thread and send their own patches.

The text is available in the sources for everyone. I see a bad
habit of reading and commenting code appearing on this list and to
start unfocused collateral bikeshedding.

If someone wants to change the body help text of clone, I suggest that
they do it in a separate thread and send patches of their own.

This patch thread here is about changing the option text for
--rev.

I don't think the current help text body of the clone command is in
such a bad shape that it makes it impossible to improve the option
text for --rev independently (as we do in THIS thread).

If we constantly have to widen the scope of discussions in such an
ad-hoc fashion, we loose a lot of time and possibly improvements
to mercurial (in the end).



More information about the Mercurial-devel mailing list