[PATCH 0 of 2] inotify: daemonizing and children pids
Benoit Boissinot
benoit.boissinot at ens-lyon.org
Thu Nov 19 19:38:25 CST 2009
On Tue, Nov 17, 2009 at 07:22:36AM -0000, Nicolas Dumazet wrote:
> Hello,
>
> Two patches:
> * First one is an important fix. It solves issue1811, but also a very
> bad regression due to 7c01599dd340, which breaks inotify when not started
> explicitely :/
> * The second patch try to solve the complains I heard yesterday, when
> test-inotify-dirty-dirstate was leaking and failing unrelated tests. It now
> allows us to set a inotify.pidfile option to know the pids of the new
> inotify children.
Pushed to stable:
changeset: 9896:2c2f7593ffc4
and
changeset: 9897:97eda2133a9b
Please resend the error messages improvements without word-wrapping.
>
> I'm thinking of passing an option/parameter to change the pid file flag from 'w'
> to 'a', to use that inotify.pidfile to list all the inotify servers started
> system-wide instead of only the last one: after this, test runner will be able
> to catch all the inotify processes and kill them before starting the next test.
> Can you think of a cleaner way to do this?
I don't see something cleaner.
cheers,
Benoit
--
:wq
More information about the Mercurial-devel
mailing list