expected test failures?

[Neal Becker]

On Friday 20 November 2009, Benoit Boissinot wrote:
> On Fri, Nov 20, 2009 at 01:56:11PM -0500, Neal Becker wrote:
> > On Friday 20 November 2009, Benoit Boissinot wrote:
> > > On Fri, Nov 20, 2009 at 11:52:37AM -0500, Neal Becker wrote:
> > > > On Friday 20 November 2009, Benoit Boissinot wrote:
> > > > > On Fri, Nov 20, 2009 at 5:01 PM, Neal Becker <ndbecker2 at gmail.com>
> >
> > wrote:
> > > > > > http://fpaste.org/O9WL/
> > > > >
> > > > > Does echo $COLUMN return something?
> > > > >
> > > > > thanks,
> > > > >
> > > > > Benoit
> > > >
> > > > No.  Tests fail when run under emacs shell.  Tests passed when run
> > > > under konsole.  Neither has $COLUMN set.  This is rediculous!
> > >
> > > does the following fixes it?
> > >
> > > diff --git a/tests/run-tests.py b/tests/run-tests.py
> > > --- a/tests/run-tests.py
> > > +++ b/tests/run-tests.py
> > > @@ -785,6 +785,7 @@
> > >      os.environ['TZ'] = 'GMT'
> > >      os.environ["EMAIL"] = "Foo Bar <foo.bar at example.com>"
> > >      os.environ['CDPATH'] = ''
> > > +    os.environ['COLUMN'] = '80'
> > >
> > >      global TESTDIR, HGTMP, INST, BINDIR, PYTHONDIR, COVERAGE_FILE
> > >      TESTDIR = os.environ["TESTDIR"] = os.getcwd()
> >
> > Yes (COLUMNS) fixes it.
> >
> > Does it have to be so fragile?
> 
> It's not fragile, we just need to have fixed settings when testing the
> output (like using LANG=C). But it's good that it adapts to the terminal
> width.
> 
> So, was emacs having $COLUMNS set?
> 
> regards,
> 
> Benoit
> 
I'll admit I haven't looked at the test code.  It's hard for me to imagine why 
it would care about the settings of my terminal.