[PATCH 0 of 1] inotify: isolate platform-independent logic

Nicolas Dumazet nicdumz at gmail.com
Tue Nov 24 21:19:35 CST 2009


Hello -devel!

Here is one of the big patches I have been developing this summer.

It basically moves inotify server code from server.py to:
  * server.py: server entry point, containing launcher and common directory
    structure/os-independent primitives. Platform-dependent imports.
  * linuxserver.py: Linux only code, extending the generic classes defined
    in server.py

It's not only useful for adding Mac Support (the Mac patch only adds a
macosserver.py and the correct "import" to server.py): it also significantly
clarifies code.

I know this patch is hard to review. I considered splitting it, but there is no
way to split it to get meaningful AND readable chunks.

Thanks :)


More information about the Mercurial-devel mailing list