[PATCH 1 of 2] commit: save commit message so it's not destroyed by rollback

Greg Ward greg-hg at gerg.ca
Fri Nov 27 10:37:09 CST 2009


On Wed, Nov 25, 2009 at 9:59 PM, Matt Mackall <mpm at selenic.com> wrote:
> There's no reason the message saved to last-commit.txt shouldn't be
> byte-identical to what was saved by the -user's editor-. If it isn't
> (because we've post-processed it to normalize it to Unix line endings)
> then that's a bug. Ideally we should save what the user gave us
> verbatim.
>
> If we always do that on principle (let's call that 'content
> neutrality'), then we can be justified in ignoring line ending,
> encoding, etc. issues.

OK, you've convinced me.  I'll resend, one last time, with no changes
to the content at all.

BTW, I agree with Nicolas that patchbomb can also annoyingly lose my
precious metadata.  And I agree with Matt that we should not delay
this patch any longer.  patchbomb's behaviour is similar but separate.

Greg


More information about the Mercurial-devel mailing list