EOL extension

[Martin Geisler]

Greg Ward <greg-hg at gerg.ca> writes:

> On Sat, Nov 28, 2009 at 3:52 PM, Martin Geisler <mg at lazybytes.net> wrote:
>> Read its help
>>
>>  hg help eol
>>
>> and test it! See the bottom of this page a TODO list:
>
> I spotted one grammatical error in the help and ended up rewriting it.
>  Sigh: how I get myself into these messes?

By being helpful? :-) Thanks for the rewrite -- I've pushed it to
Bitbucket. I also gave you write access to the repository, so feel free
to push any further changes.

> Random comments:
>
>   * shouldn't the extension's config section just be [eol]?

Good point -- the docstring had it wrong.

>   * docs should specify exactly where (which changeset) .hgeol is read
>   from.

Sure, see below.

>   * is it "native" or "NATIVE"?

It's actually case-insensitive -- so far I prefer 'native' along with
'LF', 'CRLF' and 'BIN'.

> I don't think reading .hgeol from tip is a good idea, since that can
> bounce back and forth from branch to branch.

Right, it most certainly isn't a good idea! I want it to read .hgeol
From the working copy parent revision. There's a comment about it in the
code.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20091129/77c94901/attachment.pgp>