[PATCH 0 of 3 RFC] Improve inotify test coverage

Nicolas Dumazet nicdumz at gmail.com
Mon Nov 30 21:00:16 CST 2009


Hello!

This serie was pushed, even if I was just asking for comments on that
first try, which forced a partial backout (2e67734e1453)
I'll try to be more explicit next time, "THIS IS NOT READY YET" ;)

2009/11/30 Gilles Moris <gilles.moris at free.fr>:
>> I am not sure of the right approach here.
>
> I cannot comment too much about this, as I don't know that part of code. I can
> only say that without the --inotify option, 3 tests are already failing due
> to patch 1 (append to PID file):
> Failed test-pull-http: output changed
> Failed test-push-http: output changed
> Failed test-serve: output changed

True. Maybe I was unclear, but the purpose of this mail was to try to
find a clean solution, I was not satisfied by this blunt hack into
cmdutil.py :)
Anyway, the two patches I just sent should be a cleaner way to code this.

>
> You have the detail at the end if needed.


-- 
Nicolas Dumazet — NicDumZ


More information about the Mercurial-devel mailing list