[PATCH] color: allow multiple args to ui.write()

Matt Mackall mpm at selenic.com
Thu Oct 1 13:05:56 CDT 2009


On Wed, 2009-09-30 at 22:54 -0500, Kevin Bullock wrote:
> On 30 Sep 2009, at 6:54 PM, Matt Mackall wrote:
> 
> > On Tue, 2009-09-29 at 23:59 -0500, Kevin Bullock wrote:
> >> So here's a patch to make colorwrap() accept multiple arguments. As
> >> implemented, it only colorizes the first argument; I'm not sure  
> >> that's
> >> the right way to do it and would welcome feedback.
> >
> > Yeah, it's not. For correctness, all args should be colorized.
> > Alternately, we can change ui.write to accept only one arg? Not sure  
> > how
> > often that's used, but it seems like not much.
> 
> Okay, here's a revised patch that colorizes all args. Apologies if  
> this isn't the most Pythonic way of doing it (defining an inner  
> function to use in a list comprehension). I'm happy to iterate again  
> based on feedback.

Queued for stable, thanks.

-- 
http://selenic.com : development and support for Mercurial and Linux




More information about the Mercurial-devel mailing list