[PATCH] util.rename: do not abort if os.unlink fails (issue1840)

[Adrian Buehlmann]

On 06.10.2009 20:42, Greg Ward wrote:
> On Tue, Oct 6, 2009 at 2:36 PM, Adrian Buehlmann <adrian at cadifra.com> wrote:
>>> That seems sensible to improve hg-stable in the face of broken AV scanners.
>>>
>>> <bikeshedding>
>>> But it looks like util.rename() is getting awfully hairy just to
>>> support weird Windows edge cases.  Perhaps it should be split into a
>>> one-line trivial function in posix.py, and a hairy ugly pile of
>>> Windows-specific edge cases in windows.py.  Then have util.py import
>>> one or the other.
>>> </bikeshedding>
>> Does that mean you don't want that patch?
> 
> No, I think it's a good patch if it makes life a little easier for
> people afflicted by broken AV scanners on a broken OS.

This time, it is about broken scanners, unfortunately.

I also think some of the 16'000 people who have downloaded the TortoiseHg
0.8.1 Windows installer in the last two months [1] will probably benefit
from the patch if they will get it with the 0.9 release.

Although I'd rather wish they wouldn't use such broken scanners.

[1] 0.8.2 was 8'400 downloads in 4 weeks