fulldiff (side by side diff) from sonichgextension

[Dirkjan Ochtman]

On Thu, Oct 15, 2009 at 11:43, 姚春林 <chunlinyao at gmail.com> wrote:
> The patch is FullDiff from SonicHgExtension.
> Will someone interested to integrate it in hgweb.

Hi,

Sorry for this, I think Benoit was maybe a little bit unspecific in
the tracker. Ideally, you would submit your patch through the
patchbomb extension. See the wiki for some helpful guidance on
submitting patches: http://mercurial.selenic.com/wiki/DeveloperInfo.

For one thing, this patch needs quite a bit of cleanup from a coding
style perspective (our coding style is also in the wiki). The
addwebcommand() doesn't really seem useful in this case, as you have
only one user. If you wanted to put that in a separate patch to put a
similar function somewhere in the extension machinery (similar to the
wrapcommand() function), that might actually be a good idea.

I don't think we want the menu item to be called 'fulldiff', but I
can't think of a good short name right now ('side by side diff' seems
longish). Maybe it should not be a separate item, but an option on
diff pages.

Cheers,

Dirkjan