Is extsetup() needed?

[Martin Geisler]

Brodie Rao <dackze at gmail.com> writes:

> On Oct 12, 2009, at 3:55 AM, Yuya Nishihara wrote:
>
>> Is extsetup() needed?
>
> Martin Geisler and I were chatting about this a while ago, and I think
> we both agreed that extsetup() should be deprecated.

It's been a while, but I'm not sure I think it should be deprecated any
longer -- see below :-)

> For compatibility reasons, I'm not sure it should be removed, but that
> extsetup(ui) patch in 3a78bbc57660 is silly and should be backed out
> (Martin? Anyone?).

Are you sure you mean 3a78bbc57660? That changeset merges uisetup and
extsetup in the color extension. I think that's the whole idea of
loading extensions in phases.

> Making those changes to record and highlight seems reasonable.
>
> However, one thing to keep in mind is that any extension wanting to
> modify qrecord or any other command that's added in uisetup() will
> have problems doing so depending on the order of the extensions
> loaded.

Will that not take us back to where we started?

I guess it's not very clear from the wiki right now, but if extensions
would add commands in uisetup and wrap other commands in extsetup, then
they should always be able to find each other.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20091015/939bd1d0/attachment.pgp