[PATCH 5 of 5] setup: append the latesttag to the version string for untagged versions

[Martin Geisler]

Mads Kiilerich <mads at kiilerich.com> writes:

> Gilles Moris wrote, On 10/17/2009 07:10 PM:
>> On Saturday 17 October 2009 02:40:51 am Benoit Boissinot wrote:
>>> The space and the brackets aren't very nice, especially since they
>>> end up in the filenames generated by make dist-notests / python
>>> setup.py sdist
>>>
>>> maybe sha1hash-latesttag-dist ? or latesttag+dist+sha1hash (starting
>>> with latesttag has the property that the version is comparable and
>>> bigger than the version string from the release).
>>
>> So to summarize:
>>        [A]       [B]   [C]           [D]
>> [1] archive    tag   clean =>   tag
>> [2] archive    hash  clean =>   latesttag+latesttagdistance-sha1hash
>> [3] archive    tag   dirty =>   N/A
>> [4] archive    hash  dirty =>   N/A
>> [5] clone      tag   clean =>   tag
>> [6] clone      hash  clean =>   latesttag+latesttagdistance-sha1hash
>> [7] clone      tag   dirty =>   tag+date
>> [8] clone      hash  dirty =>   latesttag+latesttagdistance-sha1hash+date
>>
>> So it's consistent, usable for file names, predictable.
>
> For consistency and immutable uniqueness it could be nice to always
> use sha1hash - also when directly on tags.
>
> That would however also affect the name and content of the official
> release tar balls, so that might not be an option? Or could that be
> solved by having an option which disables the sha1hash?

We're talking about our own build system here -- it's most important
purpose is to produce the tarballs that people download from
selenic.com. For that we don't want the hash to be included when we're
on a tag, that is sort of the idea with a tag :-)

So I think the patches are fine as they are now.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.