[PATCH 1 of 2] extensions: changed to call extsetup() from extensions.loadall()

Martin Geisler mg at lazybytes.net
Wed Oct 28 13:45:07 CDT 2009


Yuya Nishihara <yuya at tcha.org> writes:

> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1256741723 -32400
> # Node ID 045a62cbff4c5533f3aedf431f33ab1ab1411b90
> # Parent  2ae3758526d873589ab28bb704a2e106df45c773
> extensions: changed to call extsetup() from extensions.loadall()
>
> previously uisetup() was invoked by extensions.loadall(), but
> extsetup() was by _dispatch().
>
> there's no need to split them because we have nothing to do
> between uisetup() and extsetup().
>
> this fixes issue1824 indirectly.

Cool! This seems like a very nice solution to me -- letting
extensions.loadall take care of uisetup and extsetup makes sense. hgweb
uses hg.repository to load repos and so reposetup is also called.

There is no real reason to use the alternative patch you sent, is there?
I guess you made it in case this change is too invasive and in case it
affects things like TortoiseHg? I just tried it with TortoiseHg and
nothing broke :-)

I'll be happy to push it after testing it and after hearing back from
you to confirm the above.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20091028/8196b544/attachment.pgp 


More information about the Mercurial-devel mailing list