[PATCH 1 of 2] extensions: changed to call extsetup() from extensions.loadall()

[Martin Geisler]

Yuya Nishihara <yuya at tcha.org> writes:

> Martin Geisler wrote:
>> Yuya Nishihara <yuya at tcha.org> writes:
>> > # HG changeset patch
>> > # User Yuya Nishihara <yuya at tcha.org>
>> > # Date 1256741723 -32400
>> > # Node ID 045a62cbff4c5533f3aedf431f33ab1ab1411b90
>> > # Parent  2ae3758526d873589ab28bb704a2e106df45c773
>> > extensions: changed to call extsetup() from extensions.loadall()
>
>> There is no real reason to use the alternative patch you sent, is there?
>> I guess you made it in case this change is too invasive and in case it
>> affects things like TortoiseHg? I just tried it with TortoiseHg and
>> nothing broke :-)
>
> Yeah, you're right. I was afraid that this patch might break something.
> I also prefer this patch than the unclean one I posted later.

Great, thanks for the patches! I've pushed them as e0eae93e6c67 and
c4f6c02e33c4.

> TortoiseHg may work well, however, note that it has own dispatcher,
> and it calls extsetup(). see hgtk/hgtk.py:runcommand().

Good catch -- I looked at our own extensions, and it's only highlight
and record that use extsetup. It is actually safe run extsetup twice in
both cases.

That is of course only a small sample of the available extensions. I
assume TortoiseHg will stop calling extsetup from runcommand for the
version that ships with Mercurial 1.4.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20091029/8d122a55/attachment.pgp