[PATCH] inotify: _inotify.c: bugfix: remove_watch has to return PyNone on success

Benoit Boissinot benoit.boissinot at ens-lyon.org
Sat Sep 5 07:35:27 CDT 2009


On Fri, Sep 04, 2009 at 09:40:14PM -0000, Nicolas Dumazet wrote:
> # HG changeset patch
> # User Nicolas Dumazet <nicdumz.commits at gmail.com>
> # Date 1251366921 -7200
> # Node ID 545f9f3f5273d9955f200c5146d12024063bf143
> # Parent  7345fa5e572e029362bc6f2f96af452607ebb1ff
> inotify: _inotify.c: bugfix: remove_watch has to return PyNone on success
> 
> We are not currently using that API function in inotify, hence the reason
> for the "silent" bug. But returning NULL here causes the interpreter to crash.
> Let's keep code clean for reusers :)

I fixed it by removing the whole bail logic (and forgot to update the
username, I hope you don't mind).

In stable (9110:5d6659cfaa06).

cheers,

Benoit

-- 
:wq


More information about the Mercurial-devel mailing list