[PATCH] win32mbcs: util.pconvert should be wrapped

Martin Geisler mg at lazybytes.net
Thu Sep 10 14:56:06 CDT 2009


Shun-ichi GOTO <shunichi.goto at gmail.com> writes:

> 2009/9/10 Martin Geisler <mg at lazybytes.net>:
>> Thanks for turning the diff into a patch. Is it still necessary to
>> wrap windows.pconvert now that util.pconvert is being wrapped?
>
> There's no need if anyone never call windows.pconvert() in future. At
> least, there's no need with current hg code.

Right -- the mercurial.util module imports the functions from one of
mercurial.windows and mercurial.posix (depending on the platform). So
all access is normally done through mercurial.util.

> Umm... Please remove it.

Done, it's in crew-stable as revision 25c41ddb3978. Thanks for the
double-check!

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090910/75c46cdd/attachment.pgp 


More information about the Mercurial-devel mailing list