Line ending translation extension

[Dj Gilcrease]

On Thu, Sep 10, 2009 at 5:43 PM, Martin Geisler <mg at lazybytes.net> wrote:
> Dj Gilcrease <digitalxero at gmail.com> writes:
>
>> Ok following Mads Kiilerich's suggestion I created a bitbucket project
>> for the eol plugin http://bitbucket.org/digitalxero/hg-eol/overview/
>>
>> anyone who wants to help hack on it I'll add you or whatever I need to
>> to let you commit on bitbucket (dont normally use it, prefer google
>> code or assembla)
>
> Please add me to it, I'm 'mg' on bitbucket. I've made a clone with a
> test case (run 'make tests') and put it here for now:
>
>  http://bitbucket.org/mg/hg-eol/
>
> But it will probably be easier if we use a single main repository.

added

>
> I'm wondering why you added the 'bin' filter? I think it's redundant: if
> a file is binary, then don't list it in the .hgeol file and we wont
> touch it.

I added this because every file should have an associated filter,
which allows the pre-add hook to check and make sure a file is
filtered, and if not reject the add until the user added a correct
filter.

>
> Also, the global 'eol' variable is not set correctly, but I did not fix
> that yet (you obviously need to use the 'global' keyword to assign
> global variables).

Ahh ya, I always forget that (hate global vars)


> I don't think we need that -- I think it's enough that people can enable
> the eol extension in their global configuration (~/.hgrc on Unix) and
> trust that it will pick up the settings from the .hgeol file as needed.

Actually being able to set a required extension was one of the issues
brought up in the python-dev list as a requirement for this to work
"as expected".