[PATCH] win32mbcs: util.pconvert should be wrapped

Shun-ichi GOTO shunichi.goto at gmail.com
Fri Sep 18 07:37:08 CDT 2009


2009/9/10 Shun-ichi GOTO <shunichi.goto at gmail.com>:
> 2009/9/10 Martin Geisler <mg at lazybytes.net>:
>> Thanks for turning the diff into a patch. Is it still necessary to wrap
>> windows.pconvert now that util.pconvert is being wrapped?
>
> There's no need if anyone never call windows.pconvert() in future.
> At least, there's no need with current hg code.
> Umm... Please remove it.

It was my misjudgement.
By removing windows.pconvert(), util.normpath() goes unsafe.
So I make a patch to wrap util.normpath() in another mail.

By the way, TortoiseHg seems to work fine with Japanese problematic
filenames and directories with new win32mbcs.

-- 
Shun-ichi GOTO


More information about the Mercurial-devel mailing list