[PATCH] remove unused spath instance variable from localrepo and statichttprepo

Adrian Buehlmann adrian at cadifra.com
Sun Sep 20 05:30:38 CDT 2009


On 15.09.2009 16:09, Andrey Somov wrote:
> # HG changeset patch
> # User Andrey Somov <py4fun at gmail.com>
> # Date 1253023759 -7200
> # Node ID 15435d7481d4af7b40013fbc9838b7b66bfcede3
> # Parent  57d682d7d2da8af2cc7e22168075b7c246ff85e2
> remove unused spath instance variable from localrepo and statichttprepo
> 
> diff -r 57d682d7d2da -r 15435d7481d4 mercurial/localrepo.py
> --- a/mercurial/localrepo.py	Sun Sep 13 18:00:37 2009 +0200
> +++ b/mercurial/localrepo.py	Tue Sep 15 16:09:19 2009 +0200
> @@ -85,7 +85,6 @@
>                  raise
>  
>          self.store = store.store(requirements, self.sharedpath, util.opener)
> -        self.spath = self.store.path
>          self.sopener = self.store.opener
>          self.sjoin = self.store.join
>          self.opener.createmode = self.store.createmode
> diff -r 57d682d7d2da -r 15435d7481d4 mercurial/statichttprepo.py
> --- a/mercurial/statichttprepo.py	Sun Sep 13 18:00:37 2009 +0200
> +++ b/mercurial/statichttprepo.py	Tue Sep 15 16:09:19 2009 +0200
> @@ -108,7 +108,6 @@
>          def pjoin(a, b):
>              return a + '/' + b
>          self.store = store.store(requirements, self.path, opener, pjoin)
> -        self.spath = self.store.path
>          self.sopener = self.store.opener
>          self.sjoin = self.store.join

I think I kept spath for completeness sake in localrepo in 80e51429cb9a.
It was already defined before that change.

I saw there were path and opener, and I needed sopener, so
I kept spath as well probably. Why risk removing it?

In any case, what's the harm leaving it as is?



More information about the Mercurial-devel mailing list