[issue1843] crev in localrepo._filecommit get None when converting

[dbrakhane]

New submission from dbrakhane <brakhane at googlemail.com>:

While trying to convert the tortoisehg repo
(http://bitbucket.org/tortoisehg/stable) the convert process raises an
exception when reaching changeset e177b40c0b9d. Output of --debug convert:

run hg source pre-conversion action
run hg sink pre-conversion action
scanning source...
sorting...
converting...
1410 taskbar: extract SetIcon
source: e177b40c0b9dc113a27cbe8727b2b24c338cea64
thgtaskbar.py
 thgtaskbar.py: searching for copy revision for taskbar.py
run hg sink post-conversion action
run hg source post-conversion action
** unknown exception encountered, details follow
** report bug details to http://mercurial.selenic.com/bts/
** or mercurial at selenic.com
** Mercurial Distributed SCM (version 1.3.1)
** Extensions loaded: mq, record, convert
Traceback (most recent call last):
  File "/usr/bin/hg", line 27, in <module>
    mercurial.dispatch.run()
  File "/usr/lib64/python2.6/site-packages/mercurial/dispatch.py", line 16,
in run
    sys.exit(dispatch(sys.argv[1:]))
  File "/usr/lib64/python2.6/site-packages/mercurial/dispatch.py", line 27,
in dispatch
    return _runcatch(u, args)
  File "/usr/lib64/python2.6/site-packages/mercurial/dispatch.py", line 43,
in _runcatch
    return _dispatch(ui, args)
  File "/usr/lib64/python2.6/site-packages/mercurial/dispatch.py", line 449,
in _dispatch
    return runcommand(lui, repo, cmd, fullargs, ui, options, d)
  File "/usr/lib64/python2.6/site-packages/mercurial/dispatch.py", line 317,
in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/usr/lib64/python2.6/site-packages/mercurial/dispatch.py", line 501,
in _runcommand
    return checkargs()
  File "/usr/lib64/python2.6/site-packages/mercurial/dispatch.py", line 454,
in checkargs
    return cmdfunc()
  File "/usr/lib64/python2.6/site-packages/mercurial/dispatch.py", line 448,
in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
  File "/usr/lib64/python2.6/site-packages/mercurial/util.py", line 402, in
check
    return func(*args, **kwargs)
  File "/usr/lib64/python2.6/site-packages/hgext/convert/__init__.py", line
232, in convert
    return convcmd.convert(ui, src, dest, revmapfile, **opts)
  File "/usr/lib64/python2.6/site-packages/hgext/convert/convcmd.py", line
395, in convert
    c.convert(sortmode)
  File "/usr/lib64/python2.6/site-packages/hgext/convert/convcmd.py", line
329, in convert
    self.copy(c)
  File "/usr/lib64/python2.6/site-packages/hgext/convert/convcmd.py", line
301, in copy
    self.source, self.map)
  File "/usr/lib64/python2.6/site-packages/hgext/convert/hg.py", line 164,
in putcommit
    self.repo.commitctx(ctx)
  File "/usr/lib64/python2.6/site-packages/mercurial/localrepo.py", line
931, in commitctx
    changed)
  File "/usr/lib64/python2.6/site-packages/mercurial/localrepo.py", line
777, in _filecommit
    self.ui.debug(_(" %s: copy %s:%s\n") % (fname, cfname, hex(crev)))
TypeError: b2a_hex() argument 1 must be string or read-only buffer, not None

Fixing that exception would be easy of course (hexlify doesn't like a None
argument) but I'm pretty sure crev is not supposed to be None.

----------
messages: 10583
nosy: dbrakhane
priority: bug
status: unread
title: crev in localrepo._filecommit get None when converting

____________________________________________________
Mercurial issue tracker <bugs at mercurial.selenic.com>
<http://mercurial.selenic.com/bts/issue1843>
____________________________________________________