[PATCH] dirstate: add/improve method docstrings and some comments
Dirkjan Ochtman
dirkjan at ochtman.nl
Mon Sep 28 02:49:56 CDT 2009
On Mon, Sep 28, 2009 at 09:43, Adrian Buehlmann <adrian at cadifra.com> wrote:
> I'll include your comment changes (without the double spaces after period, if
> you don't mind) and offer to
Yay single spaces!
> * create a complete patch
> * apply it to crew tip
> * run the testsuite on FreeBSD with it
> * do some additional manual testing, especially on Windows. That is, test it on FAT
> to confirm it works as expected for the two second resolution case.
> * send it to the list for final review
>
> _provided_ that at least someone of crew or Matt tells me that such a patch
> has good chances for inclusion (with that unusual amount of comment).
It definitely looks like an improvement to me, although I think you
might want Matt to comment anyway.
Cheers,
Dirkjan
More information about the Mercurial-devel
mailing list