[PATCH 1 of 3] localrepo: add desc parameter to transaction

Greg Ward greg-hg at gerg.ca
Sun Apr 11 14:47:15 CDT 2010


Yayh Steve!  This will be a nice addition.  Two little comments...

On Fri, Apr 9, 2010 at 11:41 PM, Steve Borho <steve at borho.org> wrote:
> The rollback command outputs strings like these after my patches
> (these are all from the test suite):
>
> rolling back commit to revision 5
> rolling back changegroup from push to revision 1
> rolling back changegroup from pull to revision 2
> rolling back changegroup from unbundle to revision 3
> rolling back changegroup from serve to revision 1

<bikeshedding>
How about these messages:

  rolling back to revision 5 (undo commit)
  rolling back to revision 1 (undo push)
  rolling back to revision 2 (undo pull)
  rolling back to revision 3 (undo unbundle)
  rolling back to revision 1 (undo serve)

The last two are a little weird, admittedly.

Another variation:

  rollback to revision 5 (undoing commit)
  rollback to revision 1 (undoing push)
  rollback to revision 2 (undoing pull)
  rollback to revision 3 (undoing unbundle)
  rollback to revision 1 (undoing serve)

</bikeshedding>

Second: some deep gut instinct is telling me that "\n" is a better
delimiter in the undo.desc file than ",".  Not sure why I think that,
but it feels more right to me.  Maybe I want to be able to parse it
with 'head' and 'tail' in a pinch.

Greg


More information about the Mercurial-devel mailing list