[PATCH stable] mq: fixed ENOENT when qrename to new/directory.patch

[Yuya Nishihara]

Hi,

Brendan Cully wrote:
> On Thursday, 01 April 2010 at 00:10, Benoit Boissinot wrote:
> > On Wed, Mar 31, 2010 at 10:21:04AM -0700, Brendan Cully wrote:
> > > On Wednesday, 31 March 2010 at 08:37, Dirkjan Ochtman wrote:
...
> > > > I think many other separation characters could used instead, keeping
> > > > the same nice organization properties (., -, _, =, whatever), so I
> > > > don't particularly by this argument. So then it seems like a rather
> > > > slim benefit for taking into account '/' everywhere in patch names.
> > > 
> > > Couldn't you make the same argument for the main repo? Supporting
> > > subdirectories complicates things for regular hg too, so why not
> > > disallow them?
> > 
> > The difference I see is that contrary to the working dir, most mq users
> > don't touch .hg/patches, they might even not care about the way patches
> > are stored. We could urllib.quote() the filenames it probably wouldn't
> > make a difference for most people (except potential quilt users).
> > 
> > My point was more the following: contrary to the working dir, the fact
> > that patches are stored as-is isn't explicit, if I didn't knew how it
> > works I would be puzzled not to be able to have both foo and foo/bar in
> > my mq serie.
> 
> I'm sympathetic to that, but it seems that there are people (probably
> ex-quilt users) who want to be able to organize their patches into
> directories Given that, I think the inconvenience of not being able
> to have both foo and foo/bar is not as great as the inconvenience of
> not being able to use directories at all. After all, you can still
> have foo and foo.bar. I don't think that there are a large number of
> users that would be bitten by either one of these problems, but I do
> think it would be better to allow subdirectories.

Me, too. I checked mq repos on bitbucket [1], and found at least
three people use slashes '/' as patch name:

 * mjpieters: http://bitbucket.org/mjpieters/transmission-mq/src/
 * osimons: http://bitbucket.org/osimons/trac-rpc-mq/src/
 * and me :) http://bitbucket.org/yuja/redmine-mq/src/

I agree that it isn't a good number worth to support slashes everywhere,
but at least there're users, and currently mq has no critical bug
about slashes, so I don't think we need to disable that usage.

[1]: http://bitbucket.org/repo/all/?name=mq

Yuya,