[PATCH] verify: improve progress descriptions of linkref crosschecks

Eric Eisner eric.d.eisner at gmail.com
Wed Apr 14 12:59:38 CDT 2010


On Wed, Apr 14, 2010 at 12:52, Matt Mackall <mpm at selenic.com> wrote:
> On Wed, 2010-04-14 at 09:13 -0500, steve at borho.org wrote:
>> # HG changeset patch
>> # User Steve Borho <steve at borho.org>
>> # Date 1271254165 18000
>> # Node ID b5ac580a71c7c80b9578633ef452db08315222b7
>> # Parent  a6c4dd5175b55cb4b33e6c18f39dcbdb06de0439
>> verify: improve progress descriptions of linkref crosschecks
>>
>> filelinkrev and filenode are internal ideas; so I've tried to abstract
>> them as 'file links' and 'file nodes'.  In practice, these checks are
>> typically completed in a flash.
>
> Let's not do this. It looks like the progress bar is adding about half a
> second on verifying the hg repo already.

Each call to ui.progress checks the system time to see if it should
update the display. This might greatly slow down in-memory operations
that show progress. But this cost is probably nothing compared to a
file read or stat. Maybe there are other operations that really don't
benefit from the progress bar?

-Eric Eisner


More information about the Mercurial-devel mailing list